profiles: use of OneToOneField to access profile through user

profiles/viewsets/MyProfileViewSet.py

@@ -14,8 +14,7 @@ class MyProfileViewSet(viewsets.ModelViewSet):
     queryset = ProfileModel.objects.all()
 
     def get_object(self):
-        obj = self.get_queryset().get(pk=self.request.user.pk)
-        return obj
+        return self.request.user.profilemodel
 
     def perform_update(self, serializer: ProfileSerializer, pk=None):
         serializer.is_valid(raise_exception=True)

profiles/viewsets/ProfileViewSet.py

@@ -1,7 +1,7 @@
-from django.utils.translation import gettext as _
 from django.contrib.auth.models import User
+from django.shortcuts import get_object_or_404
 
-from rest_framework import permissions, status
+from rest_framework import permissions
 from rest_framework import viewsets
 from rest_framework.response import Response
 
@@ -15,21 +15,12 @@ class ProfileViewSet(viewsets.ModelViewSet):
     permission_classes = (permissions.IsAuthenticatedOrReadOnly,)
 
     def retrieve(self, request, username=None):
-        query = User.objects.filter(username=username)
-        if (not query):
-            return Response({"detail": _("Profile not found.")}, status.HTTP_404_NOT_FOUND)
-        query = self.get_queryset().filter(pk=query[0].pk)
-        if (not query):
-            return Response({"detail": _("Profile not found.")}, status.HTTP_404_NOT_FOUND)
-        instance = query[0]
-        return Response(self.serializer_class(instance).data)
+        user = get_object_or_404(User, username=username)
+        return Response(self.serializer_class(user.profilemodel).data)
 
     def retrieve_id(self, request, pk=None):
-        query = self.get_queryset().filter(pk=pk)
-        if (not query):
-            return Response({"detail": _("Profile not found.")}, status.HTTP_404_NOT_FOUND)
-        instance = query[0]
-        return Response(self.serializer_class(instance).data)
+        user = get_object_or_404(User, pk=pk)
+        return Response(self.serializer_class(user.profilemodel).data)
 
     def list(self, request):
         serializer = ProfileSerializer(self.get_queryset(), many=True)