From 916f2c3c501d6ccb5f2dae4b515fa34e1468af30 Mon Sep 17 00:00:00 2001
From: Camille Chauvet <cchauvet@1A5.42angouleme.fr>
Date: Tue, 21 Feb 2023 22:38:00 +0100
Subject: [PATCH] fix: close fd

---
 builtins/.echo.c.swp | Bin 12288 -> 12288 bytes
 builtins/echo.c      |  10 ++--------
 cmd.c                |   6 +-----
 execution.c          |   7 ++++++-
 4 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/builtins/.echo.c.swp b/builtins/.echo.c.swp
index 7361b426083084d6cefdbf78029e111509ed1d72..7ed1b8e933728625f8b75ac0705c35421192d146 100644
GIT binary patch
delta 472
zcmXBQO(??w9LDkA-z@AUb5TTFl5H_<n#h!k3&mkcQSy&jar0J_w8ca&UUo85Zg#Z(
zT;yd|a<iL@SaMp)OH!odE5G{Gb9fHFo`@PzD@WY@T|KteMvrh7kxB2z=u))aXbq<-
zv%1X#z4olDF)6B6W_d3)-|0o>ivF8wtjuN)+sz_3CXr=CF@bUP!H)`j8%4hGi7Q;<
z6el>u9(FN~F$|#-9q^(SR=gNQ^0-C@X9fw&5h0E(tYZ-ogb_plgXl#k+TlYJ95Cal
zMC2GrY-0nnn1TxynDJUH@_-!fkuDDK1tEnb64=2C<}r-{_~Ak|e%S8~x5y%cG|rJg
z9BWv>-`1fbO)1Rjwa2=kqIEmU6<u&<IHo#RwY+n`Aa>DErS~+qHMPWiF1HqPtrq+O
DZ**2%

delta 881
zcmb`^O-NKx6u|K_&PR@pq_zkqic6s5jE(a?eAAmpB|*X%)k5e4EO6eu_X>iDP*Pfq
zM35~4VHQQ?sumKps0VGTMFp+Gz*a4cAi^RNq5{E9|Codp5eOal-FvuS=W_4V=+tQ1
z)s74uRCb>(M7ziv^GEf}rQX&<C+??TMdRaRLEa9RquW!FAna)Wwy~`c7kQs(EDq`&
zDpNb%CXz-co~A@*Fo5M&kuP|S1w6qcT!aS~6=>)~H@dJDNhGk)A~KH`xQ98+;wq+b
ztVL=vOtKTb$Y2|ySWSwo;4?nqBbG3amw1MUxQpAkg&UZ`IF6zVn-Iflv&cIv;yNy1
zqPZqALUI86F@!R5=)o3rB7r!*ZV>r^MLfr2T*GCY!UzUY!Vct+MFKH==k1s9>kl5_
zPLgI8HxpqbHV~`rX@t@PuWIR)V$t@C|9ea?dVZ<DYMP$qny&7bs;>3BMzFrZYd2f#
z|Gf3zs_43Hl$Z!7GAAS9+n&vl`bu^>tmWpKj<5F&Dddz=htGPIG2e5Pp&4dDGYW>T
z48ze%j%6u#Qu*in$-G-1&Ua^bH{u`rbf@2POuJsrYpGq0Q02kB`@-}2D@{KE@@=)Q

diff --git a/builtins/echo.c b/builtins/echo.c
index 32c495b..8a3800f 100644
--- a/builtins/echo.c
+++ b/builtins/echo.c
@@ -6,11 +6,7 @@
 /*   By: erey-bet <marvin@42.fr>                    +#+  +:+       +#+        */
 /*                                                +#+#+#+#+#+   +#+           */
 /*   Created: 2023/02/17 13:09:08 by erey-bet          #+#    #+#             */
-<<<<<<< HEAD
-/*   Updated: 2023/02/21 21:45:38 by cchauvet         ###   ########.fr       */
-=======
-/*   Updated: 2023/02/21 22:09:55 by erey-bet         ###   ########.fr       */
->>>>>>> 1fdc51a668e616de94c33d5b3b1e9cb51182916d
+/*   Updated: 2023/02/21 22:15:27 by cchauvet         ###   ########.fr       */
 /*                                                                            */
 /* ************************************************************************** */
 
@@ -49,7 +45,6 @@ int	check_argument(char *str, int *check, int i)
 	return (i);
 }
 
-
 char *conca(char **strs)
 {
 	int len;
@@ -60,7 +55,7 @@ char *conca(char **strs)
 	i = -1;
 	len = 0;
 	while (strs[++i] != NULL)
-		len += strlen(strs[i]) + 2;
+		len += ft_strlen(strs[i]) + 2;
 	str = (char *) ft_calloc(len + 1, sizeof(char));
 	if (str == NULL)
 		return NULL;
@@ -74,7 +69,6 @@ char *conca(char **strs)
 	return (str);
 }
 
-
 int	echo(int fd, char **strs)
 {
 	int		check;
diff --git a/cmd.c b/cmd.c
index a3de42c..2609718 100644
--- a/cmd.c
+++ b/cmd.c
@@ -6,7 +6,7 @@
 /*   By: cchauvet <cchauvet@student.42angoulem      +#+  +:+       +#+        */
 /*                                                +#+#+#+#+#+   +#+           */
 /*   Created: 2023/02/15 14:18:21 by cchauvet          #+#    #+#             */
-/*   Updated: 2023/02/21 21:54:08 by cchauvet         ###   ########.fr       */
+/*   Updated: 2023/02/21 22:27:28 by cchauvet         ###   ########.fr       */
 /*                                                                            */
 /* ************************************************************************** */
 
@@ -22,10 +22,6 @@ void	ft_cmddel(void *ptr)
 		ft_freer_tab_ultimate(1, content->args);
 	if (content->executable != NULL)
 		free(content->executable);
-	if (content->fd_in > 2)
-		close(content->fd_in);
-	if (content->fd_out > 2)
-		close(content->fd_in);
 	free(content);
 }
 
diff --git a/execution.c b/execution.c
index 410f994..d833c55 100644
--- a/execution.c
+++ b/execution.c
@@ -6,12 +6,13 @@
 /*   By: cchauvet <cchauvet@student.42angoulem      +#+  +:+       +#+        */
 /*                                                +#+#+#+#+#+   +#+           */
 /*   Created: 2023/02/21 12:45:16 by cchauvet          #+#    #+#             */
-/*   Updated: 2023/02/21 22:11:34 by cchauvet         ###   ########.fr       */
+/*   Updated: 2023/02/21 22:26:54 by cchauvet         ###   ########.fr       */
 /*                                                                            */
 /* ************************************************************************** */
 
 #include "libftx/libftx.h"
 #include "minishell.h"
+#include <unistd.h>
 
 static char	*ft_get_executable_path(char *executable_name, t_list **env)
 {
@@ -158,6 +159,10 @@ int	ft_cmds_executor(t_data *data, t_list **cmds)
 			ft_eprintf("minishell: malloc failed\n");
 			return (1);
 		}
+		if (content->fd_in > 2)
+			close(content->fd_in);
+		if (content->fd_out > 2)
+			close(content->fd_out);
 		set_value_by_key("?", return_value, data->env);
 		current = current->next;
 	}