From fdfe1c8b95fd95579a7c93c088c414427394dfea Mon Sep 17 00:00:00 2001
From: Camille Chauvet <cchauvet@3C1.42angouleme.fr>
Date: Tue, 4 Apr 2023 13:56:21 +0200
Subject: [PATCH] fix: redirection file == redirection sign

---
 parse/parse.c             |  8 ++++++--
 redirection/check.c       | 29 +++++++++++++++++++++++------
 redirection/redirection.c | 12 ++++++++----
 3 files changed, 37 insertions(+), 12 deletions(-)

diff --git a/parse/parse.c b/parse/parse.c
index 27fbc23..f5cc5c2 100644
--- a/parse/parse.c
+++ b/parse/parse.c
@@ -6,7 +6,7 @@
 /*   By: cchauvet <cchauvet@student.42angouleme.fr  +#+  +:+       +#+        */
 /*                                                +#+#+#+#+#+   +#+           */
 /*   Created: 2023/03/27 13:44:38 by cchauvet          #+#    #+#             */
-/*   Updated: 2023/03/29 19:31:35 by cchauvet         ###   ########.fr       */
+/*   Updated: 2023/04/04 13:50:18 by alouis-j         ###   ########.fr       */
 /*                                                                            */
 /* ************************************************************************** */
 
@@ -83,7 +83,11 @@ int	ft_cmd_parser(t_data *data, char *cmd_str)
 		ft_eprintf("minishell: malloc failed\n");
 		return (1);
 	}
-	ft_redirection(data, cmd, cmd_str);
+	if (ft_redirection(data, cmd, cmd_str))
+	{
+		ft_cmddel(cmd);
+		return (1);
+	}
 	if (ft_args_parse(cmd_str, cmd))
 	{
 		ft_cmddel(cmd);
diff --git a/redirection/check.c b/redirection/check.c
index b748512..5b9284a 100644
--- a/redirection/check.c
+++ b/redirection/check.c
@@ -6,7 +6,7 @@
 /*   By: cchauvet <cchauvet@student.42angouleme.fr  +#+  +:+       +#+        */
 /*                                                +#+#+#+#+#+   +#+           */
 /*   Created: 2023/03/29 17:32:06 by cchauvet          #+#    #+#             */
-/*   Updated: 2023/03/29 19:21:59 by cchauvet         ###   ########.fr       */
+/*   Updated: 2023/04/04 13:40:29 by alouis-j         ###   ########.fr       */
 /*                                                                            */
 /* ************************************************************************** */
 
@@ -77,9 +77,26 @@ static bool	ft_check_outfile_append(t_data *data, t_cmd *cmd,
 bool	ft_check_redirection(t_data *data, t_cmd *cmd,
 				char *redirection_identifier, char *redirection)
 {
-	return (ft_check_heredoc(data, cmd, redirection_identifier, redirection)
-		|| ft_check_infile(data, cmd, redirection_identifier, redirection)
-		|| ft_check_outfile(data, cmd, redirection_identifier, redirection)
-		|| ft_check_outfile_append(data, cmd, redirection_identifier,
-			redirection));
+	char	*str;
+	bool	return_code;
+
+	if (ft_is_in("<>", redirection[0]))
+	{
+		ft_eprintf("minishell: %s: invalid redirection file\n", redirection);
+		return (1);
+	}
+	str = ft_strdup(redirection);
+	if (str == NULL)
+	{
+		ft_eprintf("minishell: malloc failed\n");
+		return (1);
+	}
+	ft_quote_remover(str);
+	return_code = (ft_check_heredoc(data, cmd, redirection_identifier, str)
+			|| ft_check_infile(data, cmd, redirection_identifier, str)
+			|| ft_check_outfile(data, cmd, redirection_identifier, str)
+			|| ft_check_outfile_append(data, cmd, redirection_identifier,
+				str));
+	free(str);
+	return (return_code);
 }
diff --git a/redirection/redirection.c b/redirection/redirection.c
index 10bc034..079fde0 100644
--- a/redirection/redirection.c
+++ b/redirection/redirection.c
@@ -6,7 +6,7 @@
 /*   By: cchauvet <cchauvet@student.42angouleme.fr  +#+  +:+       +#+        */
 /*                                                +#+#+#+#+#+   +#+           */
 /*   Created: 2023/03/27 13:44:22 by cchauvet          #+#    #+#             */
-/*   Updated: 2023/03/29 19:19:51 by cchauvet         ###   ########.fr       */
+/*   Updated: 2023/04/04 13:52:55 by alouis-j         ###   ########.fr       */
 /*                                                                            */
 /* ************************************************************************** */
 
@@ -78,11 +78,15 @@ int	ft_set_redirection(t_data *data, t_cmd *cmd, char **tab)
 	i = 0;
 	while (tab[i + 1] != NULL)
 	{
-		ft_quote_remover(tab[i + 1]);
-		if (ft_check_redirection(data, cmd, tab[i], tab[i + 1]))
-			return (1);
+
+		ft_check_redirection(data, cmd, tab[i], tab[i + 1]);
 		i++;
 	}
+	if (ft_is_in("<>", tab[i][0]))
+	{
+		ft_eprintf("minishell: %s: must be followed by a file\n", tab[i]);
+		return (1);
+	}
 	return (0);
 }